Closed ThornWalli closed 2 years ago
Thanks for working on this PR and sorry for inconveniences you had with node-fetch versioning. You weren't alone. The latest nuxt is using unjs/node-fetch-native to address most of the problems you had.
@pi0 I have seen that it is now installed, could you update the dependency node-fetch
in node-fetch-native
?
Have warnings with MaxListeners, which should then be fixed.
Sure! You can always make issue in the repos this way I can find it faster.
Hello :)
have an addition here for the test, there is still missing the retrieval of an external resource.
The whole thing has now but a background ;) we use in our package
nuxt-speedkit
the@nuxt/image
and can not update here for a long time https://github.com/GrabarzUndPartner/nuxt-speedkit/pull/521.This all came with the
ipx
update toohmyfetch
with the includednode-fetch@3
.Could find two problems:
node-fetch
update to version 3 brings errors when calling many requests.This topic can be found here:
And can be easily reproduced with the many call to http://localhost:3000/width_200/https://avatars.githubusercontent.com/u/23360933?s=500 in dev mode.
ohmyfetch.fetch
and in worst case asegment fault
jest
.I created a small repo for
ohmyfetch
, in the test you can see that the call has a problem.Therefore, this test will probably not be passed in PR.
Could I run it completely if I replaced
ohmyfetch
withnode-fetch
or changed the import to:In both cases, I had to extend the
jest
configuration withbabel
, becausenode-fetch@3
runs injest
only as ESM (https://github.com/node-fetch/node-fetch/issues/1289) and the node.mjs has to be converted as well.Now I'm asking myself, what's the next step here?
node-fetch@3
update, where one of the given PRs is included.ohmyfetch
in thejest
must work. (rollup issue?)The easiest solution would be to switch back from
ohmyfetch
tonode-fetch@2
.Thanks already for the help :)
https://github.com/unjs/ohmyfetch/issues/57