eggsy
commented
2 years ago Actually, I just figured it out, it's because createHTTPSource maps through the domains only checking if they don't start with http as it's seen here, but what it should do instead is check whether it's a protocol so at least append : at the end of that, like http:. But then, if you pass an URL that starts with https: then it would convert it to http://https://domain.com or whatever. So, best approach would be to check both if it starts with http: or https:. Here you can see the result:
Well, I just realized that this part of the code seems to be removed from the source, but it's still there on my computer, that's weird. Maybe it's passed－somehow from the image module, but I have no idea. Tried running
yarn upgradebut didn't work.Edit: Well because what I'm looking for is compiled source code, it seems to be chunked into one middleware file with combined functions from ufo, I tried installing ufo to have latest changes to
hasProtocolfunction because I see that now it's using regex instead ofnew URLas this is what I understand from here.
Hey! I believe this issue is meant to be here because I tried digging through the source of
@nuxt/image－which led to nothing, and I found out that whatever is parsing thenew URL()API from our@nuxt/imageconfig.domainsthrows an Invalid URL error whenever the domain begins with a protocol-like string. For example, I use http.cat for my error pages and put a funny cat status there. After upgrading the image module today, I saw my app wasn't starting because of this error and I started digging, after 20 minutes of searching through compiled.cjssource files, I believe this issue is directly related to your moduleipxand itscreateIPXmiddleware. Not sure though. But my code works right before that method is called. I also tried digging your source but couldn't find where my domain options reach. I will keep digging and will update this issue if I find more details. I hope this gets fixed.