Investigate `mlly.interopDefault` regression > 1.4.2 - Githubissues

unjs / jiti

Runtime TypeScript and ESM support for Node.js

MIT License

1.91k stars 62 forks source link

Investigate `mlly.interopDefault` regression > 1.4.2 #238

Closed pi0 closed 6 months ago

pi0 commented 6 months ago

Context: https://github.com/unjs/jiti/issues/237

mlly.interopDefault seems to have a regression in behavior between (last known working version) v1.4.2...v1.7.0

https://github.com/unjs/mlly/commit/14eb72d0f571e06dcd127c0d5fec7b4fa49609f9 (<-- likely this since prevents function assignment)
https://github.com/unjs/mlly/commit/5d23c98a46fefd6e812fe837cbd849164eec6b50
https://github.com/unjs/mlly/pull/243

Reproduction: (currently not a good one)

https://github.com/unocss/unocss/issues/3869 and https://github.com/facebook/docusaurus/issues/10199 might help however i could only reproduce using a jiti within node_modules which makes it strange.

pi0 commented 6 months ago

Resolved by https://github.com/unjs/mlly/pull/258 / https://github.com/unjs/jiti/commit/9adbcb30580adcb199379ef8e9d0150bba41eaae