fix(types): fix type exports

remcohaszing commented 1 month ago

🔗 Linked issue

https://github.com/twoslashes/twoslash/pull/42#discussion_r1631001129

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Jiti uses a special build step to compile the default export to export =. The generated type definitions don’t match this. To resolve this, a manual type declaration file was added.

📝 Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

pi0 commented 1 month ago

Thanks for the PR. Would you mind to target it to 1.x branch? (I'm working on another refactor that changes whole bundling system of jit 2.x)

remcohaszing commented 1 month ago

If you’re doing a semver major, I suggest another solution: Use a named export.

pi0 commented 1 month ago

Defenitly. Default will be for retro compat but yes i am planning to use ESM + named.

remcohaszing commented 1 month ago

In that case I don’t recommend merging this into the 1.x branch. Feel free to merge or close this as you like. :)

pi0 commented 1 week ago

Thanks for PR again. jiti v2 is almost ready with named { createJiti } export.

unjs / jiti