fix(lookupNodeModuleSubpath): handle conditions and nested exports

productdevbook commented 10 months ago

issua: https://github.com/unjs/mlly/issues/209

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

- Expected
+ Received

- import
+ bun

In package json the paths to bun and import are the same, but you don't have a bun file and you don't have a ts file. Therefore this output /../node_modules/.pnpm/postgres@3.4.3/node_modules/postgres/bun' is wrong. it should give the import path instead of bun.

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5213717) 86.98% compared to head (fc2f980) 87.10%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #210 +/- ## ========================================== + Coverage 86.98% 87.10% +0.12% ========================================== Files 8 8 Lines 1037 1039 +2 Branches 168 172 +4 ========================================== + Hits 902 905 +3 + Misses 135 134 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pi0 commented 10 months ago

Thanks for reproduction dear @productdevbook. I have pushed fixes on top of it 👍🏼

pi0 commented 10 months ago

Followup: https://github.com/unjs/mlly/issues/218

unjs / mlly