fix(parseStaticImport): omit empty import names

unjs / mlly

🤝 Common ECMAScript module utils

MIT License

471 stars 36 forks source link

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Hey @pi0, the last release is causing problems for imports formatted by prettier, where the comma is added at the end, like

import {
  something,
  somethingElse,
} from "package"

that causes errors in unimport:

This PR fixes that and adds a test to make sure we're covering that case. Cheers!

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.27%. Comparing base (226a47b) to head (6cbcf1b). Report is 15 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #232 +/- ## ========================================== - Coverage 88.04% 87.27% -0.78% ========================================== Files 8 8 Lines 1062 1092 +30 Branches 188 199 +11 ========================================== + Hits 935 953 +18 - Misses 127 139 +12 ```

unjs / mlly