unjs / nitro-deploys

Continues Nitro deployments for end-to-end testing deployment providers.
https://nitro.unjs.io
47 stars 8 forks source link

refactor: use emoji favicon instead of ico format #16

Closed johannschopplich closed 2 years ago

johannschopplich commented 2 years ago

I feel like that's a more 2022 solution to an ico file.

Edit: Will have to serve a placeholder for the favicon.ico to omit an extra HTTP request...

netlify[bot] commented 2 years ago

Deploy Preview for nitro-deployment ready!

Name Link
Latest commit 780119da45779a5406806e1ba31f62a6e6da9e1d
Latest deploy log https://app.netlify.com/sites/nitro-deployment/deploys/62987a5beea5d50008b275c9
Deploy Preview https://deploy-preview-16--nitro-deployment.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for nitro-deployment-edge ready!

Name Link
Latest commit 780119da45779a5406806e1ba31f62a6e6da9e1d
Latest deploy log https://app.netlify.com/sites/nitro-deployment-edge/deploys/62987a5b0ca0b300095ae349
Deploy Preview https://deploy-preview-16--nitro-deployment-edge.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

pi0 commented 2 years ago

Thanks for this PR @johannschopplich but actually it was intentional to test the serve static feature! Would you mind to copy it to a .svg file referenced by path?

johannschopplich commented 2 years ago

You're right. Thanks for the hint. Done! The new favicon is served from /favicon.svg.