[ ] ๐ Documentation (updates to the documentation, readme, or JSdoc annotations)
[x] ๐ Bug fix (a non-breaking change that fixes an issue)
[ ] ๐ Enhancement (improving an existing functionality like performance)
[ ] โจ New feature (a non-breaking change that adds functionality)
[ ] ๐งน Chore (updates to the build process or auxiliary tools and libraries)
[ ] โ ๏ธ Breaking change (fix or feature that would cause existing functionality to change)
๐ Description
Encountered this as a side effect of replicating another bug.
Registering public asset dir with a base URL of, say, /custom will lead to paths like /custom-thing also being handled by the same handler (and returning a hard 404 if fallthrough is disabled). This is because we do not test if the path begins with /custom/ but with /custom.
Let me know if you need me to provide a reproduction. I think the problem and fix are straightforward to see, but happy to do so!
๐ Linked issue
โ Type of change
๐ Description
Encountered this as a side effect of replicating another bug.
Registering public asset dir with a base URL of, say,
/custom
will lead to paths like/custom-thing
also being handled by the same handler (and returning a hard 404 if fallthrough is disabled). This is because we do not test if the path begins with/custom/
but with/custom
.Let me know if you need me to provide a reproduction. I think the problem and fix are straightforward to see, but happy to do so!
๐ Checklist