fix(prerender): skip protocol relative links - Githubissues

unjs / nitro

Next Generation Server Toolkit. Create web servers with everything you need and deploy them wherever you prefer.

https://nitro.unjs.io

MIT License

5.89k stars 496 forks source link

fix(prerender): skip protocol relative links #2661

Closed danielroe closed 1 month ago

danielroe commented 1 month ago

🔗 Linked issue

resolves https://github.com/nuxt/nuxt/issues/28525

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Came across this reported in nuxt. If a protocol relative URL is present in the HTML, for example:

<link rel="preload" as="fetch" crossorigin="anonymous" href="//xxx.cqyx.vip/statidsdfc/_payload.json?f0e0efd8-19ce-4c52-9ba9-77accf60864b">

Then /static will be crawled. We check for protocol but not for protocol relative URLs. I think checking for host should be sufficient as /static would not have a defined host but let me know if you have a better idea.

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.