feat: add option to install dependencies with a frozen lockfile

RyanClementsHax commented 3 months ago

🔗 Linked issue

Closes #115

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Closes #115

📝 Checklist

[x] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.51%. Comparing base (660392f) to head (8c6b5f3). Report is 25 commits behind head on main.

Files	Patch %	Lines
src/cli.ts	0.00%	4 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (660392f) and HEAD (8c6b5f3). Click for more details.

HEAD has 1 upload less than BASE
| Flag | BASE (660392f) | HEAD (8c6b5f3) | |------|------|------| ||3|2|

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #121 +/- ## ========================================== - Coverage 82.17% 72.51% -9.66% ========================================== Files 6 6 Lines 516 655 +139 Branches 71 85 +14 ========================================== + Hits 424 475 +51 - Misses 91 177 +86 - Partials 1 3 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

RyanClementsHax commented 3 months ago

The root error in CI seems to be this failing test that only failed on windows. The second test that failed errored because it depended on this test succeeding.

   ❯ test/api-workspace.test.ts > api > yarn-classic-workspace > adds dependency to the workspace root
     → Command failed with exit code 1: corepack yarn -W add pathe
Internal Error: ENOTEMPTY: directory not empty, rmdir 'C:\Users\runneradmin\AppData\Local\node\corepack\yarn\1.22.19\lib'

I checked locally on my windows machine if this was a reproducible problem and it doesn't seem to be. The internet seems to consider this error as ephemeral and solved by deleting node_modules and reinstalling.

I'm inclined to rerun the action because of this and the install command isn't run on the workspace fixtures. What do you think @pi0?

Also, I'd be happy to add install tests to the workspace tests. Given their lack, I wanted to see what the reasoning was for there not being any before adding them.

unjs / nypm