unjs / nypm

🌈 Unified Package Manager for Node.js and Bun
MIT License
474 stars 17 forks source link

feat: support sorting in package.json #6 #60

Closed thegostisdead closed 1 year ago

thegostisdead commented 1 year ago

This PR should close https://github.com/unjs/nypm/issues/6

codecov[bot] commented 1 year ago

Codecov Report

Merging #60 (d077315) into main (3ea7044) will increase coverage by 0.19%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   96.30%   96.50%   +0.19%     
==========================================
  Files           5        5              
  Lines         271      286      +15     
  Branches       36       38       +2     
==========================================
+ Hits          261      276      +15     
  Misses         10       10              
Impacted Files Coverage Δ
src/api.ts 94.77% <100.00%> (+0.65%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

thegostisdead commented 1 year ago

👋 Hi @pi0 sortPackageJSON function is now async.

pi0 commented 1 year ago

Hi. Sorry for delay and thanks so much on putting efforts on this pull request.

I had been thinking more about scope of nypm and checking amount of dependencies of sort-package-json, i am questioning if we should have this functionality (at least with external package).

For this i am closing this pull request but thanks again and please keep contributing ❤️