unjs / nypm

🌈 Unified Package Manager for Node.js and Bun
MIT License
439 stars 13 forks source link

refactor!: improve library #75

Closed DamianGlowala closed 10 months ago

DamianGlowala commented 1 year ago

This PR:

@pi0, are segmentation faults when using corepack with npm on ubuntu worth reporting? Will revert to the initial workaround for now anyway.

codecov[bot] commented 1 year ago

Codecov Report

Merging #75 (b953c10) into main (0e22f7f) will increase coverage by 1.48%. The diff coverage is 98.85%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   96.53%   98.02%   +1.48%     
==========================================
  Files           5        5              
  Lines         289      405     +116     
  Branches       34       64      +30     
==========================================
+ Hits          279      397     +118     
+ Misses         10        8       -2     
Files Changed Coverage Δ
src/api.ts 95.94% <98.05%> (+1.05%) :arrow_up:
src/_utils.ts 98.42% <98.42%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/package-manager.ts 100.00% <100.00%> (ø)
src/types.ts 100.00% <100.00%> (ø)
AndreyYolkin commented 11 months ago

LGTM

pi0 commented 10 months ago

Thanks so much for the time put into this PR dear @DamianGlowala ❤️

I have put a few refactors to keep the repo simplified and this mergeable.

There are really nice changes and i don't want to miss them but i couldn't do it without making a breaking change release and we lack proper changelog... therefore i ask you to please next times, consider smaller mergable PRs 🙏🏼