Closed rishi-raj-jain closed 4 months ago
Merging #82 (3f7a75d) into main (c16de18) will decrease coverage by
14.70%
. Report is 2 commits behind head on main. The diff coverage is14.94%
.
@@ Coverage Diff @@
## main #82 +/- ##
===========================================
- Coverage 98.02% 83.33% -14.70%
===========================================
Files 5 5
Lines 405 492 +87
Branches 64 64
===========================================
+ Hits 397 410 +13
- Misses 8 82 +74
Files Changed | Coverage Δ | |
---|---|---|
src/_utils.ts | 71.27% <7.40%> (-27.16%) |
:arrow_down: |
src/api.ts | 83.42% <27.27%> (-12.53%) |
:arrow_down: |
Not sure how I missed adding those deps 😅
Thanks for taking the time on fixing these...
Thanks for PR dear @rishi-raj-jain. I have made few more refactors (it is halfway done sorry in between projects). I think this is a really good start. Will followup later.
Thanks for PR dear @rishi-raj-jain. I have made few more refactors (it is halfway done sorry in between projects). I think this is a really good start. Will followup later.
Awesome! Do let me know if I can contribute. I think nypm shall also have like each function to do things, addDep, checkDep, updateDep, etc. But yeah ik the time is limited
Hi and thanks for this PR again. I think it might be better to rethink about this functionality after introducing getPackageInfo
(https://github.com/unjs/nypm/issues/7) and working with other registries.
fix #78