fix: use ascii underscore char in variable name

unjs / redirect-ssl

Connect/Express middleware to enforce https using is-https

MIT License

100 stars 15 forks source link

fix: use ascii underscore char in variable name #39

Closed matthieusieben closed 3 years ago

matthieusieben commented 3 years ago

The transpiled code shows that the ـ character used in the ـredirectURL variable name is not a regular underscore (ascii 137) but rather a 'ARABIC TATWEEL' (U+0640)

Capture d’écran 2021-05-12 à 12 51 50

matthieusieben commented 3 years ago

I personally use the very handy Highlight Bad Chars vscode extension to prevent this from occurring. Linting might help as well.

pi0 commented 3 years ago

Thanks. Javascript source is Unicode compatible but i can't believe how it went there :)