fix: generate stub types of with explicit extension import if pkg type is `module` - Githubissues

unjs / unbuild

📦 An unified javascript build system

MIT License

2.19k stars 84 forks source link

fix: generate stub types of with explicit extension import if pkg type is `module` #371

Closed yshrsmz closed 4 weeks ago

yshrsmz commented 4 months ago

🔗 Linked issue

resolve #370

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Updated DTS stub generation logic to check its module format so that it can work with ESM package.

I wanted to write test cases for this change, but there seems to be no stub-mode related tests and no idea how to write it 🤔

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

yshrsmz commented 4 months ago

@pi0 Hi, sorry to bother you, but could you take a look at this PR? I really need this fix for my project.