pi0
commented
1 month ago I appreciate your attempt to improve this but it probably won't work as expected anymore.
For cloudflare presets, we assign to globalThis.__env__ after first fetch event. It is after when the polyfill being initialized and the ref to globalThis.__env__ (undefined) at time of startup won't be updated to new process.env.
Besides, since the polyfill needs to cover other runtimes such as Deno.env which has explicit getters and setters proxy will be needed for them.
(And to add to the complexity, there are frameworks such as astro use import.meta.env.* so we cannot really simplify env support that much)
I think simplest way to disable legacy cloudflare-service-worker behavior that picks the globalThis.* would be to assign an empty object to globalThis.__env__ to disable current behavior.
We can introduce a trimmed-down polyfill via polyfill/cloudflare.ts being introduced in #183 if you like but still we need a getter method at least to allow injection after fetch.
IgorMinar
🔗 Linked issue
https://github.com/unjs/unenv/pull/183
❓ Type of change
📚 Description
The previous polyfill was unnecessarily complicated and hard to understand. Additionally it also used fallback on globalThis to read and write env variables, which in the past was used to read env variables in Cloudflare Workers in the case where workers were using the legacy service worker format. This style of workers is not actively used any more so this fallback is not needed, and in fact is undesirable as we never want to accidentaly write this globalThis.foo as a result of an assignment to process.env.foo.
The nitro utilized globalThis.env fallback is preserved as to no break nitro users.
📝 Checklist