feat(node:os): polyfill `node:os` module

jculvey commented 1 month ago

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adds a polyfill for the node:os module.

Curious for feedback on EOL and devNull. I don't see an "unimplemented" pattern in place for handling string constants exported by modules other than specifying a dummy value. LMK if y'all think there's a better value to use for either of these.

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

pi0 commented 1 month ago

@jculvey @IgorMinar i've added implementation too. Constants is little bit long (but treehsakable and when minified small). Wdyt?

IgorMinar commented 1 month ago

@jculvey if you are happy with this PR please go ahead and merge

jculvey commented 1 month ago

@jculvey if you are happy with this PR please go ahead and merge

Yup LGTM. Thanks again @pi0 for fixing this up!

unjs / unenv