feat(cloudflare): alias `node:assert/strict` to `node:assert`

unjs / unenv

🕊️ Convert javaScript code to be runtime agnostic

MIT License

342 stars 18 forks source link

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Since the workerd implementation of the node:assert module already has strict semantics, we simply need to alias node:assert/strict to node:assert to get coverage for the module.

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

According to https://nodejs.org/api/assert.html#strict-assertion-mode

In strict assertion mode, non-strict methods behave like their corresponding strict methods. For example, assert.deepEqual() will behave like assert.deepStrictEqual().

So implementing the real thing is actually less code than implementing the mocks. Could you please reexport the node:assert symbols here instead?

Yeah sure thing. Should I do that a Cloudflare specific polyfill (since nodeless doesn't have node:assert), or should we use the try/fallback approach and use these if we detect assert, otherwise fallback to notImplemented?

unjs / unenv