unjs / unenv

๐Ÿ•Š๏ธ Convert javaScript code to be runtime agnostic
MIT License
342 stars 18 forks source link

feat: polyfill `node:diagnostics_channel` module #200

Closed jculvey closed 1 month ago

jculvey commented 1 month ago

๐Ÿ”— Linked issue

โ“ Type of change

๐Ÿ“š Description

Adds a polyfill for the node:diagnostics_channel module.

๐Ÿ“ Checklist

jculvey commented 1 month ago

I might be missing something here, but it seems that this PR is unnecessary for Cloudflare.

aww shucks ๐Ÿคฆ .

I overlooked the fact that this was included in workerd. My thought process here was that I started working on dgram, and realized it had a dependency on diagnostics_channel, so I decided to pick that up first thinking it needed to be done.

๐Ÿคท

IgorMinar commented 1 month ago

hahaha.. I see. oops. ๐Ÿคฃ

well, let's have @pi0 take a look at this one and see if he likes it. I think it's a good addition to nodeless preset, but as we know it won't be used with workerd.

pi0 commented 1 month ago

Thanks!