feat(node:zlib): polyfill `node:zlib` module - Githubissues

unjs / unenv

🕊️ Convert javaScript code to be runtime agnostic

MIT License

340 stars 18 forks source link

feat(node:zlib): polyfill `node:zlib` module #230

Closed jculvey closed 1 month ago

jculvey commented 1 month ago

Replaces the current auto-mocking of zlib to support destructured ESM imports and allow for functional polyfill coverage in the future.

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

pi0 commented 1 month ago

(working on some reworks, methods need to throw error in callback properly to match spec)

pi0 commented 1 month ago

Updates:

sync methods use notImplemented as before
async methods use new util that throws error on callback and implements promisify
base compress/decompress class therows error on constructor.
compression formats moved to separate modules

Followup idea: https://github.com/unjs/unenv/issues/235