search

unjs / unenv

🕊️ Convert javaScript code to be runtime agnostic
MIT License
464 stars 22 forks source link

`createHmac` (from `node:crypto`) is not implemented for nodeless targets #291

Open zou-yu opened 3 months ago

zou-yu commented 3 months ago

Environment

nodejs20 "nuxt": "^3.12.3", wrangler:

compatibility_date = "2024-07-01"
compatibility_flags = ["nodejs_compat"]

Reproduction

Just enable nodejs-compat in wrangler and using cloudlfare_module preset, you will get the same error: [unenv] crypto.createHmac is not implemented yet!

Describe the bug

Cannot use createHmac in cloudflare worker with cloudflare_module preset, got error: [unenv] crypto.createHmac is not implemented yet! but createHmac is supported in cloudflare worker: https://developers.cloudflare.com/workers/runtime-apis/nodejs/crypto/

Additional context

No response

Logs

[unenv] crypto.createHmac is not implemented yet!
Flowko commented 2 months ago

would love to see this implemented, the only thing stopping me from using it with lucia auth.

vicb commented 1 month ago

@zou-yu @Flowko this is now implemented (natively) in cloudflare.

@pi0 not sure if you want to close this issue or leaving it open for nodeless

pi0 commented 1 month ago

@vicb

  1. unenv support is not limited to cloudflare
  2. even for cloudflare we cannot upgrade to unenv v2 for Nitr/Nuxt because of the blockers I shared with you

This issue is not solved at least for original reported problem.

vicb commented 1 month ago

Thanks for the clarification @pi0!

  1. unenv support is not limited to cloudflare

Yep, that's why I asked about closing this PR.

  1. even for cloudflare we cannot upgrade to unenv v2 for Nitr/Nuxt because of the blockers I shared with you

I thought the reported issue was solved. I didn't consider v1 vs v2.

radum2o18 commented 3 weeks ago

any updates on this issue? would also love to see this implemented. thank you!