search

unjs / unenv

🕊️ Convert javaScript code to be runtime agnostic
MIT License
464 stars 22 forks source link

chore: add cloudflare team to workerd tests codeowners #326

Closed IgorMinar closed 1 month ago

IgorMinar commented 1 month ago

This came out of https://github.com/unjs/unenv/pull/325 which we should be able to approve and merge without @pi0 but we can't right due to the OWNERS config not being up todate.

pi0 commented 1 month ago

I wish this were discussed in one of the proper channels we already have but here is a quick context:

Nitro (and Nuxt) use unenv injections by default even if users don't specify node_compat in their wrangler config (which is opt-in) we need to make sure tests also cover this situation. (nodeless only)

In the next steps (of #311), I am planning to enable the same tests in a matrix with/without node_compat to cover the above.

I think it is fair to ask we wait until then.

Afterwards, when the cloudflare team updates tests we make sure they also cover the nodeless state.