search

unjs / unenv

🕊️ Convert javaScript code to be runtime agnostic
MIT License
465 stars 22 forks source link

CI does not catch workerd test failures #327

Closed vicb closed 1 month ago

vicb commented 1 month ago

Environment

CI

Reproduction

See

Describe the bug

The workerd tests fails - see the linked PR for more info but the CI is green

Additional context

-

Logs

workerd/server/server.c++:3851: debug: [ TEST ] tests:buffer_implements
[server] unenv/runtime/node/buffer from /tests
workerd/io/worker.c++:2065: info: uncaught exception; source = Uncaught (in promise); stack = TypeError: Failed to execute 'isAscii' on 'BufferUtil': parameter 1 is not of type 'ArrayBuffer or ArrayBufferView'.
    at Module.isAscii (node-internal:internal_buffer:1763:23)
    at Object.test (tests:39:22)
workerd/util/symbolizer.c++:158: warning: llvm-symbolizer was not found. To symbolize stack traces, install it in your $PATH or set $LLVM_SYMBOLIZER to the location of the binary. When running tests under bazel, use `--test_env=LLVM_SYMBOLIZER=<path>`.
workerd/io/io-context.c++:352: info: uncaught exception; exception = workerd/jsg/_virtual_includes/jsg/workerd/jsg/value.h:1372: failed: jsg.TypeError: Failed to execute 'isAscii' on 'BufferUtil': parameter 1 is not of type 'ArrayBuffer or ArrayBufferView'.
workerd/server/server.c++:3859: debug: [ FAIL ] tests:buffer_implements