Add octokit types for better DX

unjs / ungh

🐙 Unlimited access to github API

https://ungh.cc

MIT License

514 stars 12 forks source link

Add octokit types for better DX #80

Closed cpreston321 closed 8 months ago

cpreston321 commented 9 months ago

Describe the feature

Currently the data is any coming back from the fetch endpoint with types you can know what to expect from githubs side.

Additional information

[X] Would you be willing to help implement this feature?

pi0 commented 9 months ago

Good point. But think github should not break the types and not worth the complexity to add types from another tool that gets propagation time if ever github changes something. (and it is internal)

cpreston321 commented 8 months ago

I guess that makes since, I guess it's hard to figure out the data without looking at the response types since the version of the api is defined in the headers for using github REST API itself.

pi0 commented 8 months ago

Yes. that's why i'm thinking ungh can provide a typed client. (maybe after https://github.com/unjs/ofetch/pull/371)

let's track via https://github.com/unjs/ungh/issues/4