Closed tropicalraisel closed 3 years ago
Can you sync the latest changes of unplugin-starter
template? Namely: https://github.com/antfu/unplugin-starter/commit/61b6a51d3b83d9ad6dbf733be918bf8e92a19482
Is there a command series that let's me do that with a template? I'm unfamiliar working with templates.
EDIT: I found this method but forgot the merge. EDIT 2: It refuses to merge unrelated histories.
I've applied the fixes here: https://github.com/TropicalRaisel/unplugin-skypin/commit/68e127a900f808e3e46b190b701cb750bfb3d01a
But I'm still having the same problems.
Is how I'm implementing my custom resolver correct? https://github.com/TropicalRaisel/unplugin-skypin/blob/main/src/index.ts#L21
Ah, I see, you are resolving ids to remote URLs. I am not sure if webpack supports it out-of-box. You might need some extra loader I guess
@antfu Right now I'm having trouble just getting Rollup to work xd Webpack also just doesn't seem to be even loading the plugin, so I don't know if this functionality is working there or not. I tried configuring Rollup to allow externals like your docs say, but that doesn't work either: https://github.com/TropicalRaisel/unplugin-skypin/blob/main/src/index.ts#L29
I've confirmed vite
is working! May you give me some more info on how the framework-specific options work for webpack
and rollup
? I'm trying to declare externals to rollup
like so:
rollup: {
name,
api: {
external: true,
},
},
But nothing seems to happen. I feel like somehow rollup
needs to know it's an external in order to let it through.
Do you have a working rollup example?
It doesn't work, but shows the error.
I mean, without unplugin, to make sure your logic works first
The logic just returns a Skypack URL, so yes it works. The whole plugin works perfectly in Vite. Just be sure the remote packages are defined in packages
, since for some reason package imports like src
and C
were attempted to be changed without the filter.
I believe to have figured out how to handle Rollup compatbility. The Skypack URLs would have to be placed in an external
array that gets passed to Rollup. Then it should work. The only issue is how to do it well, and I've opened two new issues detailing some features that would help do so.
Current implementation: unplugin-skypin
Rollup Issues
Example: unplugin-skypin-demo Follow the commands given to get this error:
Rollup Dependencies
Webpack Issues
Imported like so:
Generates this error:
And trying this:
Gives a
TypeError: Skypin is not a function
.Webpack Dependencies
Notes
Maybe there's something simple I'm missing here, but I've followed all the given examples and easily accessible information to the best of my ability. Thanks for your work!