search

unjs / unwasm

🇼 WebAssembly tools for JavaScript
MIT License
172 stars 6 forks source link

`resvg` compatibility #20

Open harlan-zw opened 6 months ago

harlan-zw commented 6 months ago

Environment

unwasm: 0.3.7 node: 18.18.0

Reproduction

https://stackblitz.com/edit/stackblitz-starters-rugrtg?file=package.json

Describe the bug

Resvg requires calling initWasm before using it in a WASM context. This function only takes the module as non-initialized module. Unwasm will always initialize the module.

Additional context

No response

Logs

No response

pi0 commented 6 months ago

Working on https://github.com/unjs/unwasm/pull/23, i hope it can help to support resvg-js sooner.

pi0 commented 6 months ago

Updated: https://stackblitz.com/edit/stackblitz-starters-4rizt7?file=src%2Findex.ts,build.config.ts

harlan-zw commented 6 months ago

Amazing, thank you! The demo looks good, I'll test further with Nuxt OG Image and make a new issue if there are any further issues.

pi0 commented 6 months ago

(keeping this open to not forget, might move to single tracker issue, finally we have to help upstream packages like resvg-js be ESM compatible)