unjs / webpackbar

Elegant ProgressBar and Profiler for Webpack 3 , 4 and 5
MIT License
2.07k stars 66 forks source link

Support webpack 5 #73

Closed otakustay closed 3 weeks ago

otakustay commented 4 years ago

What problem does this feature solve?

I used webpackbar with webpack 5 for a while and found no compatibility issue, since npm 7 requires peer dependencies to match strictly, it is better to publish a new version upgrading peerDependencies to enable webpack 5

This feature request is available on Nuxt community (#c47)
pi0 commented 4 years ago

Hi! Thanks for notice about NPM. Same here we are also using it for nuxt3 with wp5 without any special issues.

nicholas-ochoa commented 4 years ago

I'm having issues installing it (when no package-lock.json is present from npm 6.x):

$ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: @company/api@2.6.4
npm ERR! Found: webpack@5.1.3
npm ERR! node_modules/webpack
npm ERR!   dev webpack@"^5.1.3" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^3.0.0 || ^4.0.0" from webpackbar@4.0.0
npm ERR! node_modules/webpackbar
npm ERR!   dev webpackbar@"^4.0.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/username/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/username/.npm/_logs/2020-10-19T20_22_41_253Z-debug.log

npm install --legacy-peer-deps works for now, but this package will definitely need to be updated

Tom910 commented 4 years ago

I founded 1 problem with webpack 5 is broken feature profile. But main feature work fine

pi0 commented 4 years ago

Hi. Webpack5 support is almost finished (6ba2f820fb1d668608a33b31fea836ac08ee4f4d) releasing soon && sorry for delay

ckken commented 4 years ago

Hi. Webpack5 support is almost finished (6ba2f82) releasing soon && sorry for delay

thanks

ckken commented 3 years ago

mark

thasmo commented 3 years ago

Happens now in webpack 5 projects on npm install with npm@7:

npm ERR! Could not resolve dependency:
npm ERR! peer webpack@"^3.0.0 || ^4.0.0" from webpackbar@4.0.0
npm ERR! node_modules/webpackbar
npm ERR!   webpackbar@"^4.0.0" from the root project
alexander-akait commented 3 years ago

Maybe we don't need this plugin and move bar style to webpack core? Should be easy. Will be great to get feedback and improve built-in output and nobody need this plugin anymore, less deps and no problems with update

/cc @pi0

pi0 commented 3 years ago

Webpack5 ready plugin is already available as webpackbar@v5.0.0-3 (pre-release tag) :) I will run some final tests and mark at latest.

Maybe we don't need this plugin and move bar style to webpack core? Should be easy. Will be great to get feedback and improve built-in output and nobody need this plugin anymore, less deps and no problems with update

It would be a really nice idea if we can port this functionality directly into the webpack core. The most tricky part is multi-line output control. I guess we need to first extract bar functionality and then we can propose it :)

alexander-akait commented 3 years ago

It would be a really nice idea if we can port this functionality directly into the webpack core. The most tricky part is multi-line output control. I guess we need to first extract bar functionality and then we can propose it :)

Yep, feel free to feedback, I will help :star:

thasmo commented 3 years ago

@pi0 Has there been any progress on webpack 5 compatibility since ... then? 😅 Would love to use webpackbar with webpack 5. ❤️

pi0 commented 3 weeks ago

webpack5 is tested in main branch.

If there is any (reproducable) issues with wp5 support please report in a new issue 🙏🏼