unkeyed / unkey

Open source API management platform
https://go.unkey.com
Other
2.53k stars 242 forks source link

chore: added navigation if no keys on page #1837

Open MichaelUnkey opened 2 days ago

MichaelUnkey commented 2 days ago

What does this PR do?

eng-1049 Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

How should this be tested?

Verify create key and back buttons function

Checklist

Required

Appreciated

Huly®: ENG-1831

linear[bot] commented 2 days ago

ENG-1049 keys page navigation is broken

changeset-bot[bot] commented 2 days ago

⚠️ No Changeset found

Latest commit: cecb4d4f3ba9baf392304ad525d9ba24936ac44a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 2:51pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 2:51pm
3 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **planetfall** | ⬜️ Ignored ([Inspect](https://vercel.com/unkey/planetfall/FxuuVDt2LUaPZ4yvs3CXyaMr3RyZ)) | [Visit Preview](https://planetfall-git-eng-1049-keys-page-navigation-is-broken-unkey.vercel.app) | | Jul 2, 2024 2:51pm | | **play** | ⬜️ Ignored ([Inspect](https://vercel.com/unkey/play/XbTTT8QKNMJxQ13SeRhM4w9CtKwP)) | [Visit Preview](https://play-git-eng-1049-keys-page-navigation-is-broken-unkey.vercel.app) | | Jul 2, 2024 2:51pm | | **workflows** | ⬜️ Ignored ([Inspect](https://vercel.com/unkey/workflows/6hscPR5GvUiPMcap1Mn6G57rAEoK)) | [Visit Preview](https://workflows-git-eng-1049-keys-page-navigation-is-broken-unkey.vercel.app) | | Jul 2, 2024 2:51pm |
github-actions[bot] commented 2 days ago

Thank you for following the naming conventions for pull request titles! 🙏

chronark commented 5 hours ago

CleanShot 2024-07-03 at 18 20 33@2x Can you please horizontally align the buttons, this doesn't look good.