search

unkeyed / unkey

Open source API management platform
https://go.unkey.com
Other
2.67k stars 267 forks source link

Remove precommit hooks. #1896

Closed perkinsjr closed 1 month ago

perkinsjr commented 1 month ago

Remove pre commit hooks. They slow down a developer for no reason when we have checks and balances in places through CI like. Formatting, Linting, Type checks.

linear[bot] commented 1 month ago

ENG-1233 Remove precommit hooks.

chronark commented 1 month ago

fwiw I disagree, it costs more time and energy to find out you forgot to format something after you have pushed compared to before committing, biome is super fast

but I don't care enough to challenge this

ovaistariq commented 1 month ago

It’s actually the opposite. Validating in the CI, issues that can be caught on developer machine will slow down the development.

tobiastornros commented 1 month ago

I agree, but this assumes that the CI setup is fast.

perkinsjr commented 1 month ago

fwiw I disagree, it costs more time and energy to find out you forgot to format something after you have pushed compared to before committing, biome is super fast

but I don't care enough to challenge this

commit versus push are two different things.

I don't want to have to format every commit to the standard we have, WIP commits when context switching require 2-3x more time. I use --no-verify almost 90% of the time I do because precommit blocks me.

Our CI for linting / formatting (what we use) is fast enough. I will leave this open to discussion.