unkeyed / unkey

Open source API management platform
https://go.unkey.com
Other
3.97k stars 464 forks source link

apis.listKeys should support externalId #1965

Closed Flo4604 closed 2 months ago

Flo4604 commented 2 months ago

Preliminary Checks

Is your feature request related to a problem? Please describe.

The listKeys API currently only supports using the ownerId as a parameter, but should also take in a externalId CleanShot 2024-07-23 at 18 01 31@2x

Describe the solution

The api should be adjusted to allow the usage for an externalId/ownerId, ownerId should then be marked as deprecated like in the other APIs.

Describe alternatives you have considered (if any)

No response

Additional context

Currently this is not an issue as ownerId === externalId but should be changed for completeness sake.

Flo4604 commented 2 months ago

would be happy to take this on

linear[bot] commented 2 months ago

ENG-1277 apis.listKeys should support externalId

chronark commented 2 months ago

thanks, let's go!

chronark commented 2 months ago

accidentally did this today :)