[X] This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.
Reproduction / Replay Link (Optional)
No response
Issue Summary
When using multiple ratelimits, we check all limits serially and reject if one of them is exceeded. However this means previously checked limits are incremented regardless of subsequent checks and could be incremented falsely if we end up rejecting the request later.
Steps to Reproduce
Use an identity with mulitple limits
set one limit high and one low
trigger the lower limit
observe how the upper limit's counter still increments
Expected behavior
Counters should only be incremented if none of the limits are exceeded
linear[bot]
commented
1 month ago
Preliminary Checks
[X] I have reviewed the documentation: https://unkey.com/docs
[X] I have searched for existing issues: https://github.com/unkeyed/unkey/issues
[X] This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.
Reproduction / Replay Link (Optional)
No response
Issue Summary
When using multiple ratelimits, we check all limits serially and reject if one of them is exceeded. However this means previously checked limits are incremented regardless of subsequent checks and could be incremented falsely if we end up rejecting the request later.
Steps to Reproduce
Expected behavior
Counters should only be incremented if none of the limits are exceeded
Other information
No response
Screenshots
No response
Version info