unkeyed / unkey

Open source API management platform
https://go.unkey.com
Other
4.25k stars 505 forks source link

Display the city rather than the IP address in the audit logs #2247

Open harshsbhat opened 1 month ago

harshsbhat commented 1 month ago

Preliminary Checks

Is your feature request related to a problem? Please describe.

Currently we display the IP address in the audit logs which looks something like this:

image

Describe the solution

But as the end user, I would be more interested in the city or a location which is humanly readable rather than something like IP address

Describe alternatives you have considered (if any)

No response

Additional context

No response

linear[bot] commented 1 month ago

ENG-1398 Display the city rather than the IP address in the audit logs

chronark commented 1 month ago

The new logs @ogzhanolguncu is working on may provide insights into that, but we'll have to discuss it it's not trivial to turn an ip into more geo information

ogzhanolguncu commented 1 month ago

@chronark I know it's not the same thing, but maybe we can use this: https://developers.cloudflare.com/ruleset-engine/rules-language/fields/standard-fields/#ipsrcsubdivision_2_iso_code ?

chronark commented 1 month ago

@ogzhanolguncu do you mean showing the isocodes like GB-SWK?

maybe yeah, we still gotta get that information though. It's fairly easy to get on cloudflare, but as we're migrating our API over to aws, we need to figure out how to get that kind of data

ogzhanolguncu commented 1 month ago

Okay, I see your point now. We can introduce 3rd party for the lookup, but that might be too costly on our end. We should definitely discuss 👍🏻

mrjayantbokade commented 1 month ago

/assign