unkeyed / unkey

Open source API management platform
https://go.unkey.com
Other
3.78k stars 440 forks source link

Fix: Pagination Error in Blog Section #2320

Open Kiran-pande-30 opened 4 days ago

Kiran-pande-30 commented 4 days ago

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

  1. When navigating the blog section, the URL incorrectly updates to negative page numbers (page=-1, page=-2) if a user tries to go beyond the first page.
  2. Similarly, the URL updates to non-existing future page numbers when there are no more pages to display.

Steps to Reproduce

  1. Unkey Home Page
  2. Blog Section
  3. Scroll to pagination
  4. Click on the navigation before 1 & after 2

Expected behavior

We can disable the navigation arrows at both extreme ends of the pagination. This will restrict the users to go beyond the actual blog length.

Other information

No response

Screenshots

PFA Video for the issue

https://github.com/user-attachments/assets/ededfa5c-4786-44c5-b100-87a0e61d215a

Version info

- OS: Windows 11
- Browser: Chrome
linear[bot] commented 4 days ago

ENG-1419 Fix: Pagination Error in Blog Section

saadcode1 commented 4 days ago

/assign

souvikjs01 commented 4 days ago

/assign

Kiran-pande-30 commented 4 days ago

Hello maintainers, I would love to work on this issue

Kiran-pande-30 commented 4 days ago

/assign

yashthakare93 commented 4 days ago

/assign

Suman1999-hub commented 4 days ago

/assign

NawinKumarSharma commented 4 days ago

/assign

chronark commented 4 days ago

/award 150

oss-gg[bot] commented 4 days ago

Awarding Kiran-pande-30: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Kiran-pande-30

Aryant01 commented 4 days ago

/assign

oss-gg[bot] commented 4 days ago

Assigned to @Aryant01! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

biswa2005 commented 4 days ago

\assign

biswa2005 commented 4 days ago

/assign

oss-gg[bot] commented 4 days ago

This issue is already assigned to another person. Please find more issues here.

Kiran-pande-30 commented 4 days ago

@chronark why not this issue was not assigned to me? I have studied and prepared the solution workflow for this issue

chronark commented 3 days ago

because you tried to assign yourself before we unlocked the issue by adding points

Kiran-pande-30 commented 3 days ago

because you tried to assign yourself before we unlocked the issue by adding points

Can I get it reassigned now? 🙂

chronark commented 3 days ago

if Aryant01 does not submit a PR within 48h it will be open again

sonii-Rahul commented 3 days ago

/assign

oss-gg[bot] commented 3 days ago

This issue is already assigned to another person. Please find more issues here.

NawinKumarSharma commented 3 days ago

i have already linked a PR #2330 which closes the issue. can you assign me and review the pr? @MichaelUnkey @perkinsjr @chronark

chronark commented 3 days ago

@NawinKumarSharma , no the current assignee is Aryant01, you can claim this issue in case they do not provide a PR

hr188 commented 3 days ago

/assign

oss-gg[bot] commented 3 days ago

This issue is already assigned to another person. Please find more issues here.

roshan-29 commented 3 days ago

/assign

oss-gg[bot] commented 3 days ago

This issue is already assigned to another person. Please find more issues here.

pravin130794 commented 3 days ago

/assign

oss-gg[bot] commented 3 days ago

This issue is already assigned to another person. Please find more issues here.

mr-rayeen commented 2 days ago

/assign

oss-gg[bot] commented 2 days ago

This issue is already assigned to another person. Please find more issues here.

kunalarya873 commented 1 day ago

/assign

oss-gg[bot] commented 1 day ago

This issue is already assigned to another person. Please find more issues here.

NawinKumarSharma commented 1 day ago

/assign

oss-gg[bot] commented 1 day ago

This issue is already assigned to another person. Please find more issues here.

NawinKumarSharma commented 19 hours ago

@chronark , i think there is no pr raised from the assignee and i have already raised the pr which solves the issue and since my pr is linked to this issue so i think the current assignee of this issue is not unassigned yet even after 3 days???

mr-rayeen commented 10 hours ago

@chronark plz assign this to me its been more than 48hr and assignee yet not submitted there PR. I would Like to work on this.