Ratelimit's `New Override` form displays repeated form errors

unrenamed commented 1 week ago

Preliminary Checks

[X] I have reviewed the documentation: https://unkey.com/docs
[X] I have searched for existing issues: https://github.com/unkeyed/unkey/issues
[X] This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

When filling out the "New Override" form for the Ratelimit feature, users experience repeated form errors appearing both under the relevant input fields and in the same block as the "Create" button. If multiple errors occur, the second error message rewrites, showing only the last invalid input. Additionally, there is an issue with font size and weight inconsistency for the error messages.

The question is whether this is expected behaviour?

Steps to Reproduce

Navigate to the ratelimit's page and select the "Overrides" tab
Fill out the required fields with valid input
Click the "Create" button (this will activate the form validation)
Now, put an empty string to any of the form inputs
Notice the error messages displayed twice: under the actual input and another one below
See how the error message styles differ, noting inconsistencies in font size and weight

Expected behavior

The expected behaviour must be approved with the repo owners first. Here are my suggestions:

Instead of overwriting, show all errors related to multiple invalid fields individually and clearly under their respective fields.
If repeated errors are intended, standardize the font size and weight for error messages to ensure a consistent appearance across the form.