unkeyed / unkey

Open source API management platform
https://go.unkey.com
Other
4.24k stars 503 forks source link

Empty Toast When Attempting to Set Unverified Email as Primary #2514

Open unrenamed opened 2 weeks ago

unrenamed commented 2 weeks ago

Preliminary Checks

Reproduction / Replay Link (Optional)

No response

Issue Summary

When a user tries to make an unverified email address their primary email, the application shows an empty toast notification, providing no feedback or error message.

Steps to Reproduce

  1. Log into your account.
  2. Navigate to the profile settings or account settings page.
  3. Add a new email address but do not verify it.
  4. Attempt to make the unverified email address your primary email.
  5. Observe the toast notification.

Expected behavior

When a user attempts to set an unverified email as their primary email:

Or the button "Make Primary" should not be available in an unverified email dropdown at all.

Other information

No response

Screenshots

https://github.com/user-attachments/assets/cdc4747d-1f8c-4b58-aea8-ac34ccac9b69

Version info

- OS:
- Node:
- npm:
linear[bot] commented 2 weeks ago

ENG-1521 Empty Toast When Attempting to Set Unverified Email as Primary

SandipGyawali commented 2 weeks ago

@unrenamed are you working on this issue ? i'm thinking of collaborating to the project after approval can i look at this issue it will be very helpful as well as thankful..

unrenamed commented 2 weeks ago

Let's wait for @chronark 's approval first. This issue may already be addressed as part of the auth/user account refactoring by the core team. See https://github.com/unkeyed/unkey/issues/2201#issuecomment-2395019106

chronark commented 2 weeks ago

yeah, auth related things are currently being worked on by @mcstepp /award 50

oss-gg[bot] commented 2 weeks ago

Awarding unrenamed: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/unrenamed