API: unkey-version header returning unknown - Githubissues

unkeyed / unkey

Open source API management platform

https://go.unkey.com

Other

4.28k stars 511 forks source link

API: unkey-version header returning unknown #2615

Open Flo4604 opened 1 month ago

Flo4604 commented 1 month ago

Preliminary Checks

[X] I have reviewed the documentation: https://unkey.com/docs
[X] I have searched for existing issues: https://github.com/unkeyed/unkey/issues
[X] This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

The Unkey-Version header which normally shows the unkey version always returns unknown

Steps to Reproduce

Send a request to https://api.unkey.dev Check the unkey-version header

Expected behavior

It should return the version (github commit/hash) again

Other information

This got changed somewhere in between here CleanShot 2024-10-30 at 10 49 40@2x

Screenshots

No response

Version info

Irrelevant

linear[bot] commented 1 month ago

ENG-1570 API: unkey-version header returning unknown

Flo4604 commented 1 month ago

Interestingly the canary deployments have the version set, see the latest failed run: https://github.com/unkeyed/unkey/actions/runs/11575910749/job/32228117890

chronark commented 1 month ago

/award 50 yeah, probably a small mistake we used to inject this in ci manually, but iirc cloudflare now have a native way to use such metadata

oss-gg[bot] commented 1 month ago

Awarding Flo4604: 50 points 🕹️ Well done! Check out your new contribution on oss.gg/Flo4604