Login page shows weird, when logging out

[bipulpoudel]

Preliminary Checks

• [X] I have reviewed the documentation: https://unkey.dev/docs

• [X] I have searched for existing issues: https://github.com/unkeyed/unkey/issues

• [X] This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.dev/discord.

Reproduction / Replay Link (Optional)

No response

Description

The login page is shown weird css when you get redirected after signout.

Environment

No response

[perkinsjr]

This is because of Dark mode. We never do any dark mode for our sign in pages. Should be fairly simple to hard code the classnames to use bg white

[bipulpoudel]

I can pick this up? I have fixed it.

[bipulpoudel]

I have added dark mode in sign-in page, should we not add it? Because, the ThemeProvider cache is giving this error.

[bipulpoudel]

I have created this:

I guess, it looks good though?

[perkinsjr]

Dark mode should not be added to the sign in and sign up

[bipulpoudel]

Aah okayy, I would fix it by removing cache then :)

[perkinsjr]

Or you could just set the colors to bg-white and bg-black across the board and leave the cache alone so the user next log in doesn't get reverted

[bipulpoudel]

Sounds like a plan :), Thanks

[bipulpoudel]

Hi @perkinsjr , one silly question, is it okay to add theme provider as light in layout for auth?

It is working perfectly fine, no change in code needed at all, but is it something we can do?

Something like this:

Code wise, it's much cleaner but not sure, if this is recommended, didn't find anything in next documentation

[perkinsjr]

There is no need to add a theme provider. We have zero plans to add light or dark mode.

[bipulpoudel]

@perkinsjr , I have created PR :)

[bipulpoudel]

This is fixed :), closing issue now.