Add a toast message for create key

unkeyed / unkey

Open source API management platform

https://go.unkey.com

Other

4k stars 468 forks source link

Add a toast message for create key #749

Closed ErrolFernandes closed 7 months ago

ErrolFernandes commented 9 months ago

Preliminary Checks

[X] I have reviewed the documentation: https://unkey.dev/docs
[X] I have searched for existing issues: https://github.com/unkeyed/unkey/issues
[X] This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.dev/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

when in Create key page -The page refreshes when you click the 'create key' button on the top right corner. -replace the page refresh route with a toast message

Steps to Reproduce

1.click on create key button on top right 2. it goes to create key page 3. click again on the create key button on the top right 4. refresh occurs

Expected behavior

to show a toast message

Other information

No response

Screenshots

No response

Version info

- OS:windows
- Browser:chrome

linear[bot] commented 9 months ago

ENG-348 Add a toast message for create key

perkinsjr commented 9 months ago

How does this toast message improve the UX of someone clicking the create key and refreshing the page for the user so the state etc has been removed?

ErrolFernandes commented 9 months ago

We could just add a reset button next to the create button below.

perkinsjr commented 9 months ago

If the user creates a key, we have that already. There is a button to "Create another Key"

The only time we don't have a reset form, is when the user is in the middle of creation because they can enable disable the advanced features. (or will be able too with the latest release)

Below is an example in WIP

ErrolFernandes commented 9 months ago

No we are talking about different things I'm just suggesting to show a toast because users absent mindedly click on the top right create key button when the create key page is already there. edge case UX.

perkinsjr commented 9 months ago

Can you provide more details in the issue.

So we can properly understand the "issue" the resolution, and how it helps the user.

What you expect, what you want etc.

ErrolFernandes commented 9 months ago

This happens https://github.com/unkeyed/unkey/assets/83249470/5315fe66-f46f-4dc6-8792-2eafa23bb1cf it refreshes let it just show a toast. gives a visual indicator to the user.

perkinsjr commented 9 months ago

What do you want the toast to say? I still don't understand how a toast makes the UX better.

ErrolFernandes commented 9 months ago

'You're already on the create page'