sourcery-ai[bot]
commented
3 weeks ago Reviewer's Guide by Sourcery
This PR adds IAR memory mapping test functionality and includes a minor modification to error source handling for RH850U2C2 OSTM category. The implementation focuses on parsing IAR map files to extract symbol information and adds a specific product condition check in error source handling.
Sequence diagram for readIarMap method
sequenceDiagram
participant Tester as MemoryMappingTest
participant FileUtil as FileUtils
participant ResourceUtil
participant SymbolList as List<Symbol>
Tester->>ResourceUtil: getResource("iar.map")
ResourceUtil-->>Tester: File path
Tester->>FileUtil: readLines(file, UTF_8)
FileUtil-->>Tester: List<String> content
loop for each line in content
alt line equals iarSymbolFlag
Tester->>Tester: inSymbol = true
else line contains iarGlobalVarFlag
Tester->>SymbolList: add(Symbol)
end
end
Tester->>Tester: print symbolsClass diagram for MemoryMappingTest modifications
classDiagram
class MemoryMappingTest {
- String iarSymbolFlag = "*** ENTRY LIST"
- String iarGlobalVarFlag = "Data Gb"
+ void readIarMap() throws IOException
}
class Symbol {
- String name
- String address
- int size
}Class diagram for AbstractU2XFamilyScript modification
classDiagram
class AbstractU2XFamilyScript {
+ void handlerErrorSourceMap(Map<String, Object> errorSource, String product, int optErrortIndex)
}File-Level Changes
| Change | Details | Files |
|---|---|---|
| Added support for reading and parsing IAR map files |
|
qe/src/test/java/com/tlcsdm/qe/MemoryMappingTest.java |
| Modified error source handling logic for specific product category |
|
smc/src/main/java/com/tlcsdm/smc/codeDev/ecm/AbstractU2XFamilyScript.java |
vercel[bot]
naming-conventions-bot[bot]
quine-bot[bot]
coderabbitai[bot]
what-the-diff[bot]
sonarcloud[bot]
github-actions[bot]
GitHub
Fixes #
Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
enhancement,bug,documentationordependenciesSummary by Sourcery
Introduce a new test for parsing IAR map files and enhance error source map handling in AbstractU2XFamilyScript.
Enhancements:
Tests:
Summary by CodeRabbit
新功能
MemoryMappingTest类中添加了readIarMap()方法，以支持处理新的iar.map文件格式。变更
AbstractU2XFamilyScript类中修改了handlerErrorSourceMap方法，增加了对特定产品和类别组合的处理逻辑，优化了控制流。