unknowIfGuestInDream / tlstudio

Currently includes SWT examples, and will support jface and other examples in the future
Eclipse Public License 2.0
2 stars 0 forks source link

feat: Add com.tlcsdm.tlstudio.widgets #196

Closed unknowIfGuestInDream closed 1 month ago

unknowIfGuestInDream commented 1 month ago

Fixes #

Proposed Changes

  1. ...
  2. ...
  3. ...

Readiness Checklist

Author/Contributor

Reviewing Maintainer

Summary by Sourcery

Add a new package 'com.tlcsdm.tlstudio.widgets' introducing several custom widgets including RangeSlider, Slider, DoubleSpinner, and ChromaticityDiagram. These widgets provide enhanced UI components for handling numeric ranges, precision inputs, and chromaticity visualization. Additionally, a utility class is added for common operations.

New Features:

Enhancements:

Summary by CodeRabbit

quine-bot[bot] commented 1 month ago

👋 Figuring out if a PR is useful is hard, hopefully this will help.

  • @unknowIfGuestInDream has been on GitHub since 2019 and in that time has had 1090 public PRs merged
  • Don't you recognize them? They've been here before 🎉
  • Here's a good example of their work: javafxTool (Javafx scaffolding, built on JDK17 + JavaFX21 + controlsfx 11.x.x + Maven)
  • From looking at their profile, they seem to be good with Java and HTML.

Their most recently public accepted PR is: https://github.com/unknowIfGuestInDream/tlstudio/pull/193

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request adds several new custom widgets and utility classes to the com.tlcsdm.tlstudio.widgets package. The changes include implementations for range sliders, spinners, color pickers, and chromaticity diagrams, as well as various supporting classes and utilities.

Class diagram for new widgets in com.tlcsdm.tlstudio.widgets

classDiagram
    class RangeSlider {
        - byte NONE
        - byte UPPER
        - byte LOWER
        - byte BOTH
        - int minWHint
        - int minHHint
        - int barHeight
        - int hOffset
        - int vOffset
        - Color selectionColor
        - double minimum
        - double maximum
        - double lowerValue
        - double upperValue
        - Image slider
        - Image sliderHover
        - Image sliderDrag
        - Image sliderSelected
        - Image vSlider
        - Image vSliderHover
        - Image vSliderDrag
        - Image vSliderSelected
        - int orientation
        - int increment
        - int pageIncrement
        - byte selectedElement
        - byte priorSelectedElement
        - boolean dragInProgress
        - boolean upperHover
        - boolean lowerHover
        - double previousUpperValue
        - double previousLowerValue
        - double startDragUpperValue
        - double startDragLowerValue
        - Point startDragPoint
        - boolean hasFocus
        - boolean isSmooth
        - boolean isFullSelection
        - boolean isHighQuality
        - boolean isOn
        - Format toolTipFormatter
        - String clientToolTipText
        - NumberFormat numberFormat
        + RangeSlider(Composite parent, int style)
        + int getStyle()
        + void addSelectionListener(SelectionListener listener)
        + Point computeSize(int wHint, int hHint, boolean changed)
        + int getIncrement()
        + double getLowerValue()
        + double getMaximum()
        + double getMinimum()
        + int getPageIncrement()
        + double[] getSelection()
        + double getUpperValue()
        + void removeSelectionListener(SelectionListener listener)
        + void setIncrement(int increment)
        + void setLowerValue(double value)
        + void setMaximum(double value)
        + void setMinimum(double value)
        + void setExtrema(double min, double max)
        + void setPageIncrement(int pageIncrement)
        + void setSelection(double[] values)
        + void setSelection(double lowerValue, double upperValue)
        + void setUpperValue(double value)
        + void setNumberFormat(NumberFormat numberFormat)
    }

    class Slider {
        - double minimum
        - double maximum
        - double value
        - int xPosition
        - int mouseDeltaX
        - Color barInsideColor
        - Color barBorderColor
        - Color barSelectionColor
        - Color selectorColor
        - Color selectorColorBorder
        - int horizontalMargin
        - int selectorWidth
        - int selectorHeight
        - int barHeight
        - NumberFormat numberFormat
        - double movingValue
        - boolean moving
        - int minWHint
        + Slider(Composite parent, int style)
        + void addSelectionListener(SelectionListener listener)
        + Point computeSize(int wHint, int hHint, boolean changed)
        + void setBounds(int x, int y, int width, int height)
        + void setEnabled(boolean enabled)
        + void removeSelectionListener(SelectionListener listener)
        + double getMinimum()
        + void setMinimum(double minimum)
        + double getMaximum()
        + void setMaximum(double maximum)
        + double getValue()
        + void setValue(double value)
        + void setBarInsideColor(Color barInsideColor)
        + void setBarBorderColor(Color barBorderColor)
        + void setBarSelectionColor(Color barSelectionColor)
        + void setSelectorColor(Color selectorColor)
        + void setSelectorColorBorder(Color selectorColorBorder)
        + void setHorizontalMargin(int horizontalMargin)
        + void setSelectorWidth(int selectorWidth)
        + void setSelectorHeight(int selectorHeight)
        + void setBarHeight(int barHeight)
        + void setNumberFormat(NumberFormat numberFormat)
    }

    class CIEData1931 {
        + static List~CIEData~ getInstance()
    }

    class DoubleSpinnerCellEditor {
        - DoubleSpinner spinner
        - FocusAdapter focusListener
        - KeyListener keyListener
        + DoubleSpinnerCellEditor(Composite parent)
        + DoubleSpinnerCellEditor(Composite parent, int style)
        + Control createControl(Composite parent)
        + void dispose()
        + Object doGetValue()
        + void doSetFocus()
        + LayoutData getLayoutData()
        + void doSetValue(Object value)
        + void applyEditorValueAndDeactivate()
        + void focusLost()
        + void setMaximum(double i)
        + void setMinimum(double i)
        + DoubleSpinner getSpinner()
        + int getDoubleClickTimeout()
        + void setIncrement(double inc)
        + void setFormat(int i, int j)
        + void setBounds(Rectangle bnds)
        + void addKeyListener(KeyListener listener)
        + void addSelectionListener(SelectionListener listener)
    }

    class CIE1931ChromaticityDiagram {
        + CIE1931ChromaticityDiagram(Composite parent, int style)
        + void drawOutLines(GC gc)
    }

    RangeSlider --|> AbstractCustomCanvas
    Slider --|> AbstractCustomCanvas
    DoubleSpinnerCellEditor --|> CellEditor
    CIE1931ChromaticityDiagram --|> ChromaticityDiagram
    CIEData1931 --o CIEData

File-Level Changes

Change Details Files
Added custom RangeSlider widget
  • Implemented RangeSlider class with support for horizontal and vertical orientations
  • Added methods for setting minimum, maximum, and current values
  • Implemented mouse and keyboard event handling for user interaction
  • Added customization options for colors and appearance
bundles/src/com/tlcsdm/tlstudio/widgets/custom/RangeSlider.java
Added custom Slider widget
  • Implemented Slider class with support for double values
  • Added methods for setting minimum, maximum, and current values
  • Implemented mouse event handling for user interaction
  • Added customization options for colors and appearance
bundles/src/com/tlcsdm/tlstudio/widgets/custom/Slider.java
Added CIE color model support
  • Implemented CIEData class to represent color data points
  • Added CIEData1931 class with predefined color data
  • Implemented ChromaticityDiagram and CIE1931ChromaticityDiagram classes for visualizing color spaces
bundles/src/com/tlcsdm/tlstudio/widgets/model/CIEData.java
bundles/src/com/tlcsdm/tlstudio/widgets/model/CIEData1931.java
bundles/src/com/tlcsdm/tlstudio/widgets/color/ChromaticityDiagram.java
bundles/src/com/tlcsdm/tlstudio/widgets/color/CIE1931ChromaticityDiagram.java
Added custom cell editors for table viewers
  • Implemented DoubleSpinnerCellEditor for editing double values
  • Added SpinnerCellEditor for integer values
  • Implemented BooleanCellEditor for checkbox-style editing
  • Added QeColorCellEditor for color selection
  • Implemented QeCheckBoxCellEditor for checkbox editing
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/DoubleSpinnerCellEditor.java
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/SpinnerCellEditor.java
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/BooleanCellEditor.java
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/QeColorCellEditor.java
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/QeCheckBoxCellEditor.java
Added utility classes and supporting components
  • Implemented AbstractCustomCanvas as a base class for custom widgets
  • Added WidgetsUtility class with helper methods for resource management and logging
  • Implemented ImageToolitp class for displaying image tooltips
  • Added AbstractCheckBoxCellLabelProvider as a base class for checkbox cell label providers
bundles/src/com/tlcsdm/tlstudio/widgets/custom/AbstractCustomCanvas.java
bundles/src/com/tlcsdm/tlstudio/widgets/WidgetsUtility.java
bundles/src/com/tlcsdm/tlstudio/widgets/window/ImageToolitp.java
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/AbstractCheckBoxCellLabelProvider.java

Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).
coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes introduced in this pull request involve the addition of several new files and configurations for an Eclipse-based project. Key additions include project configuration files (.classpath, .project, and settings), a manifest file, utility classes for managing color data and user interface components, and custom cell editors for various controls. These enhancements improve the project's structure, support for Java SE 17, and provide new graphical components for user interaction.

Changes

File Change Summary
bundles/.classpath New file created defining classpath configuration for Eclipse project.
bundles/.project New file created defining project configuration for com.tlcsdm.tlstudio.widgets.
bundles/.settings/org.eclipse.jdt.core.prefs New configuration file for Eclipse JDT settings with Java 17 compiler options.
bundles/META-INF/MANIFEST.MF New manifest file for Tlcsdm Widgets bundle with attributes for versioning and dependencies.
bundles/build.properties New build properties file specifying source and output directories.
bundles/src/com/tlcsdm/tlstudio/widgets/WidgetsUtility.java New utility class for managing plugin resources and logging.
bundles/src/com/tlcsdm/tlstudio/widgets/color/CIE1931ChromaticityDiagram.java New class for creating a CIE 1931 chromaticity diagram.
bundles/src/com/tlcsdm/tlstudio/widgets/color/ChromaticityDiagram.java New class for graphical representation of chromaticity data with customizable features.
bundles/src/com/tlcsdm/tlstudio/widgets/custom/AbstractCustomCanvas.java New abstract class for custom canvas components with enhanced event handling.
bundles/src/com/tlcsdm/tlstudio/widgets/custom/DoubleSpinner.java New custom widget for handling double precision numbers with a spinner control.
bundles/src/com/tlcsdm/tlstudio/widgets/custom/RangeSlider.java New class for a dual-thumb slider control allowing range selection.
bundles/src/com/tlcsdm/tlstudio/widgets/custom/Slider.java New class for a customizable slider control for numeric values.
bundles/src/com/tlcsdm/tlstudio/widgets/model/CIEData.java New class encapsulating color data in the CIE color space with conversion methods.
bundles/src/com/tlcsdm/tlstudio/widgets/model/CIEData1931.java New class providing access to CIE 1931 color data using a singleton pattern.
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/AbstractCheckBoxCellLabelProvider.java New abstract class for custom label provider for checkbox cells.
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/BooleanCellEditor.java New class for a custom checkbox cell editor.
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/DoubleSpinnerCellEditor.java New class for a cell editor utilizing a double spinner control.
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/QeCheckBoxCellEditor.java New class for a checkbox cell editor with custom behavior.
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/QeColorCellEditor.java New class enhancing color selection through a custom color cell editor.
bundles/src/com/tlcsdm/tlstudio/widgets/viewers/SpinnerCellEditor.java New class for a spinner cell editor managing numeric values.
bundles/src/com/tlcsdm/tlstudio/widgets/window/ImageToolitp.java New class for a tooltip displaying an image.
releng/com.tlcsdm.tlstudio.examples.swt.rcp/src/com/tlcsdm/tlstudio/examples/swt/rcp/Activator.java Minor formatting change, removal of a blank line in the Activator class.

Poem

In the garden where widgets bloom,
New tools arise to banish gloom.
With spinners and sliders, colors so bright,
Our Eclipse project takes flight!
Hopping through code, a joyful delight,
For every change, a new path in sight! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.