unknown-horizons / godot-port

Unknown Horizons Godot Engine Port
https://www.unknown-horizons.org
GNU General Public License v2.0
663 stars 83 forks source link

Fix corrupted UIDs and do some code cleanup #115

Closed artism90 closed 1 year ago

artism90 commented 1 year ago

Fixes #113.

Resaved all files dealing with UIDs in the following order:

  1. all scene files
  2. all tres files
  3. all scene files again

They were previously gone but came back at some point. In case that the warnings should return once again, the next attempt will be to wipe all existing UIDs per Search & Replace from each .tscn and .tres and then repeat the process to see if it will then set up all UIDs correctly.

Also cleaned up the code at some parts, especially removed band-aid logic related to cached node variables used in getter/setter methods to prevent issues in Godot 3 which appear to be non-existent now.

And also minor theme tweaking.