search

unknown-horizons / godot-port

Unknown Horizons Godot Engine Port
https://www.unknown-horizons.org
GNU General Public License v2.0
665 stars 83 forks source link

Use GDQuests code guidelines? #36

Closed Jummit closed 5 years ago

Jummit commented 5 years ago

GDQuest has made some cool guidelines for GDscript / Godot in general I think we could use: https://github.com/GDquest/kickstarter-quest-3/blob/4765997a54413022ff5c1a4e29eaf7b31f8ceaa6/docs/code-guidelines.md I find them super useful for collaborating and also just for my own projects. They are meant for 3.1, but maybe we can use them when we switch to that version.

aaronfranke commented 5 years ago

Why does he use stray colons before equal signs? Don't equal signs by themselves work fine?

plexsoup commented 5 years ago

Don't equal signs by themselves work fine?

They're trying to use static typing. ( var variableName : typeName = value ) Godot will attempt to infer a type if you omit the type name. ( var variableName : = value ) I'm not sure why they've decided to omit the type names though.

YeldhamDev commented 5 years ago

We're currently in 3.0.6, so we'll have to wait to use typing, but's definitely in the plans!

Jummit commented 5 years ago

Here we go! 3.1 is out and we can start porting to it! (And use these guidelines!)

YeldhamDev commented 5 years ago

As with 4670b3d, I think this can be closed now.