search

unknown-horizons / godot-port

Unknown Horizons Godot Engine Port
https://www.unknown-horizons.org
GNU General Public License v2.0
665 stars 83 forks source link

Building Base Type #38

Closed yigitozdemir closed 5 years ago

yigitozdemir commented 5 years ago

Added base scene for building. Building scenes like stone_house may be created via extending base Building scene.

We can develop common method and attributes in Building.tscn and Building.gd.

YeldhamDev commented 5 years ago

This is not right, WorldThing is supposed to be a low level class to anything that visually appears in the world, and not a Building class of its own. A new Building class should be made inheriting WorldThing's script and scene.

yigitozdemir commented 5 years ago

I'll update source according to your comment tomorrow. It's seems like you are rights. That might be better for for this case.

yigitozdemir commented 5 years ago

WorldThing came back. Now, Building scene extends WorldThing also Stone_house scene extends building.

YeldhamDev commented 5 years ago

I jumped in and did a basic layout of how this should go (ac1a15f0c0b0b2fc5e5b4385e87aa0aa414ef079). Created two classes: Building, which inherents WorldThing, and Residence, which inherents Building. For now, they're just empty scripts, which hopefully will change soon.

I also added the ".DS_Store" files to ".gitignore" in a separated commit (fc32e588e1fdfbe3a3a5019e7971e11a4f0d1cc1).