search

unknown-horizons / godot-port

Unknown Horizons Godot Engine Port
https://www.unknown-horizons.org
GNU General Public License v2.0
681 stars 86 forks source link

Build MacOs dmg file #53

Closed baptistemesta closed 4 years ago

baptistemesta commented 4 years ago

Hi,

I think it would be nice to export the game for MacOs. Tested it right now, It looks like it works as expected.

Calinou commented 4 years ago

Note that exporting a DMG file can only be done from macOS as it depends on system utilities. On other platforms, you can only export to a ZIP archive containing the application bundle.

baptistemesta commented 4 years ago

Note that exporting a DMG file can only be done from macOS as it depends on system utilities. On other platforms, you can only export to a ZIP archive containing the application bundle.

I did not know that, I expected it to work since I was able to generate .exe on mac. If this does not work on other platforms, we can revert it or I can change the behavior to only generate .dmg optionally.

aaronfranke commented 4 years ago

Can you add an if statement to detect MacOS, and only execute these lines if it is MacOS?

baptistemesta commented 4 years ago

I'll try

baptistemesta commented 4 years ago

Done here: https://github.com/unknown-horizons/godot-port/pull/54