Closed benoit-germain closed 10 years ago
Hi, you're absolutely right - I've neglected this for far too long. I'll start by formally allocating a bit of time to maintaining Decoda but I'd be very happy to pass this onto a willing & able individual (providing that Max & Charlie agree).
My efforts stalled about a year ago when after merging in a bunch of pull requests, the resulting build was not up to scratch and I just didn't have time to delve deeper. Luckily - merging in later fsfod's pull requests fixes the biggest issues and I pushed an updated version of the dev branch that now has all the pull requests except for the Lua 5.2 support.
I'll get some people to test the dev build next week and if it's solid I can merge it into master and release an official 1.17 binary. Then we can have some fun with the 5.2 support.
-D
With Lua 5.3 coming along, I'd be happy to implement the port again, but I'd rather do it on an official reference codebase that contains all the latest developments, Lua 5.2 support included.
Is there some ETA on such a beast?
In my mind the dev branch was the official reference codebase but I guess that was pretty non-idiomatic. I merged it into master, which I believe now has most of the pull requests except for the 5.2 support.
I created a beta release of what's there right now so hopefully more people will test it. My test environment is Natural Selection 2 which uses Lua 5.1 so I can't really test your 5.2 changes. However if you give me a pull request that you believe works fine, I'm happy to just merge it in and push a new beta release for others to go wild with. Looking forward to the 5.3 stuff too! :)
Thanks,
-D
I haven't changed anything since my original pull request besides the two subsequent commits to support __towatch on tables. I've been using it for several months now and it seems to work fine. Sometimes the callstack display shows strange stuff but I am not sure it is my fault or not.
Would you mind redoing the pull request against the latest master? It won't merge automatically right now because of the other stuff that changed and I don't want to mess up the merge. Thanks!
It's in progress, should be over soon. I am in the process of rebuilding wx libs to resolve link issues because I have Visual 2012 and the commited wx libs are built with visual 2013.
Done (I think). Apparently everything I commit in my branch automatically gets added to my previous pull request for some reason.
It didn't merge cleanly unfortunately so I had a stab at doing it manually (in master now). Could you please check that it works ok with Lua 5.2?
Re: tinyxml & wx, I'm planning to add premake support for them so we can compile with various versions of Visual Studio.
When I compare the two HEAD snapshots of my own branch and your master branch the only differences are whitespace lines in LuaDll.cpp and DebugBackend.cpp so I'd say it didn't go too bad.
I suppose this particular issue can be closed then.
Hi,
It's been several months now that bugfixes and other improvements have been proposed, without anything done about them.
I can understand that you may not have the time to manage Decoda maintenance, but in that case maybe it would be a good idea to open commit rights to other people if another maintainer manifests him/her-self?
If the official branch if left unattended for too long, I fear it will simply die. It would be better if a single endorsed version could be the reference instead of having everyone fork his own.