unknwon / com

This is an open source project for commonly used functions for the Go programming language.
Apache License 2.0
755 stars 133 forks source link

fix case-insensitive import collision #24

Closed lizhengqiang closed 5 years ago

lizhengqiang commented 5 years ago

fix case-insensitive import collision

Krystian19 commented 5 years ago

@unknwon Please accept this change, i'm getting installation errors because of it.

unknwon commented 5 years ago

This change alone won’t solve the problem I think, I need to roll back some changes regarding Go mod name.

unknwon commented 5 years ago

Since my GitHub handle converted to lower case for long-term purpose. And research a lot on other repos faced similar issue, I think this is a must have step to forward on updating import path.

If you're getting errors on a specific package, just ping me and I'll send out PR to those repos.

I truly apology for any unintended troubles made!

Krystian19 commented 5 years ago

@unknwon I'm getting an error while installing https://github.com/Unknwon/bra

go get github.com/Unknwon/bra

Stacktrace

go: finding github.com/Unknwon/bra latest
go: finding github.com/Unknwon/log latest
go: finding github.com/Unknwon/com latest
go: downloading github.com/Unknwon/com v0.0.0-20190804042917-757f69c95f3e
go: extracting github.com/Unknwon/com v0.0.0-20190804042917-757f69c95f3e
go: github.com/Unknwon/com@v0.0.0-20190804042917-757f69c95f3e: parsing go.mod: unexpected module path "github.com/unknwon/com"
go: error loading module requirements
unknwon commented 5 years ago

@Krystian19 thanks! Updating it.

unknwon commented 5 years ago

@Krystian19 updated, would you mind try again? go get github.com/unknwon/bra, thanks for the quick follow up!

Krystian19 commented 5 years ago

@unknwon It works like a charm, Thank you !!

Great job with Bra BTW, it's the best one i've found.

unknwon commented 5 years ago

@Krystian19 no problem, my pleasure :D

@lizhengqiang which package you're trying to download/install? I can send out PRs as well.

lizhengqiang commented 5 years ago

123Step 32/76 : RUN go get github.com/go-macaron/cache 124 ---> Running in 34955ce7ad0f 125package github.com/Unknwon/com: case-insensitive import collision: "github.com/Unknwon/com" and "github.com/unknwon/com"

unknwon commented 5 years ago

@lizhengqiang thanks, fixed!