unkontributors / super_unko

Super Unko project is the one of the awesome, clean and sophisticated OSS projects in the world.
Other
174 stars 21 forks source link

Fix tar2rpm/tar2deb version 1.0.1 #85

Closed greymd closed 4 years ago

greymd commented 4 years ago

tar2package 編集するつもりなんですがビルド落ちるのが怖いのでバージョン固定します。

Check list

greymd commented 4 years ago
$ docker-compose build super_unko
Building super_unko
Step 1/10 : FROM ubuntu:19.04
19.04: Pulling from library/ubuntu
4dc9c2fff018: Pull complete
0a4ccbb24215: Pull complete
c0f243bc6706: Pull complete
5ff1eaecba77: Pull complete
Digest: sha256:2adeae829bf27a3399a0e7db8ae38d5adb89bcaf1bbef378240bc0e6724e8344
Status: Downloaded newer image for ubuntu:19.04
 ---> c88ac1f841b7
Step 2/10 : RUN echo -e $'\n_人人人人人人人人人人人人人人人人人人人人人人_\n> super_unkoイメージ
れには少し時間がかかるよ!       <\n ̄Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^ ̄\n   
 (💩👁💩👁💩)\n  (💩💩💩👃💩💩💩)\n (💩💩💩💩👄💩💩💩💩)'
 ---> Running in ea4352b86134
-e $
_人人人人人人人人人人人人人人人人人人人人人人_
> super_unkoイメージを今からビルドするよ! <
> これには少し時間がかかるよ!       <
 ̄Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^Y^ ̄
      👑
    (💩💩💩)
   (💩👁💩👁💩)
  (💩💩💩👃💩💩💩)
 (💩💩💩💩👄💩💩💩💩)
Removing intermediate container ea4352b86134
 ---> 4c6181f9418f
Step 3/10 : ENV LANG ja_JP.UTF-8
 ---> Running in e5607286c965
Removing intermediate container e5607286c965
 ---> 92a0a61b2c50
Step 4/10 : RUN apt update -yqq     && apt install -y --no-install-recommends        toilet
  curl        ca-certificates        locales     && locale-gen ja_JP.UTF-8     && rm -rf /var/lib/a
 ---> Running in 7b7a1f9ca725

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

E: The repository 'http://security.ubuntu.com/ubuntu disco-security Release' does not have a Releas
E: The repository 'http://archive.ubuntu.com/ubuntu disco Release' does not have a Release file.

CI が落ちると思ったら、Disco はライフサイクル切れにてリポジトリアクセスできなさそう。20.04にあげます。

greymd commented 4 years ago
------------------------------------------------------------------------------
GNU bash, version 3.2.0(1)-release (x86_64-unknown-linux-gnu)
Copyright (C) 2005 Free Software Foundation, Inc.
------------------------------------------------------------------------------
super_unko-test.bats
1..9
/usr/libexec/bats-core/bats-exec-test: line 205: syntax error in conditional expression: unexpected token `('
/usr/libexec/bats-core/bats-exec-test: line 205: syntax error in conditional expression: unexpected token `('
/usr/libexec/bats-core/bats-exec-test: line 205: syntax error in conditional expression: unexpected token `('
/usr/libexec/bats-core/bats-exec-test: line 205: syntax error in conditional expression: unexpected token `('
/usr/libexec/bats-core/bats-exec-test: line 205: syntax error in conditional expression: unexpected token `('

Ubuntu 20.04 にあげたら、次はbash 3.2 で何やらエラーが。 bats 側でシンタックスエラーで落ちているらしい。

greymd commented 4 years ago

現状 apt でインストールできる bats 1.2.0 のサポートする bash バージョンは3.2.57以降のようなので(link) bash 3.2 のテストで利用されるバージョンを 3.2.0 から 3.2.57にあげる。 また別のエラーが。 https://github.com/unkontributors/super_unko/pull/85/checks?check_run_id=704094245

yacc -d ./parse.y
make: yacc: Command not found
make: *** [Makefile:571: y.tab.c] Error 127

yaccがないので、Dockerfileyaccのインストールも追加。

greymd commented 4 years ago

@jiro4989 CI周りにいくつか変更を加えたので一応みていただければ..

jiro4989 commented 4 years ago

LGTM 👍

LGTM