unlayer / react-email-editor

Drag-n-Drop Email Editor Component for React.js
https://unlayer.com/embed
MIT License
4.51k stars 728 forks source link

Unlayer Types not correct for the newer version #399

Closed willianjusten closed 3 months ago

willianjusten commented 3 months ago

Hey guys, I just saw you updated Unlayer to it's new version, but I also noticed that the unlayer-types package is not updated yet.

If I try to use the classic_light version, my TS fails because it does not have this type there. I saw the package and indeed, it's not there.

image

Also, is there a list of latest versions of the Unlayer editor so I can lock correctly? I can't find anywhere...

brunolemos commented 3 months ago

We have an internal fix for that! It's not available yet. You can make ts ignore that line for now.

We don't have a list of versions, but I believe that is something we will be doing from now on and they'll be available in the Docs Changelog: https://docs.unlayer.com/changelog

willianjusten commented 3 months ago

Would you mind telling me the latest version prior this theme update?

brunolemos commented 3 months ago

@willianjusten 1.5.75

What did the new version break for you?

willianjusten commented 3 months ago

Ah, so it's the same as in the Docs you sent me, perfect. It broke most of the Custom CSS stuff because some classes changed and there are also some new visuals. Nothing big and we're already with a task to fix that, but I didn't want to have anything broken (even thought is not in prod yet).

brunolemos commented 3 months ago

@willianjusten cool! thanks for letting me know

show us the customization later if you can :)

willianjusten commented 3 months ago

Sure, I'll let you know as soon as we release this new feature. It will come in the next few months =)

brunolemos commented 3 months ago

We released a new unlayer-types version with the fix! Thanks.