search

unlayer / react-email-editor

Drag-n-Drop Email Editor Component for React.js
https://unlayer.com/
MIT License
4.64k stars 744 forks source link

Component calls home #56

Closed DigitalFlow closed 5 years ago

DigitalFlow commented 5 years ago

Hey there,

I really like the editor, so first off thanks for publishing it.

What I'm wondering about however: When loading the editor sends a GET request to one of your servers, passing the current domain as parameter, like the following: https://adminapi.unlayer.com/v1/editor/0?domain=yourdomain.com.

Could you tell which other data you send to your servers? In addition to that, as your editor is being loaded as iframe, I think people might feel a little bit more secure if you used the sandbox property of iframes.

Thanks in advance.

Kind Regards, Florian

Edit: Just saw that several events also send requests with the full refferer url: URL: https://adminapi.unlayer.com/v1/editor/0/events Payload: {"type":"editorReady","referrer":"http://domain.com/path/emaileditor.html?pagemode=iframe"} Examples for these events are the editorReady event on load and the exportHtml function for getting the editor's current state.

I'm not really happy about this, is this solely for telemetry?

adeelraza commented 5 years ago

@DigitalFlow these events are sent to Unlayer servers to track usage and make sure our premium services are not enabled on domains that are not whitelisted for those features. If you are not using a premium license, this wouldn't really matter.

DigitalFlow commented 5 years ago

@adeelraza Alright, thanks for sharing that information.

I hope that you'll have success with your business model, but what is going to happen, if you for any reason decide to discontinue this editor? Since it is a wrapper component, will it die immediately? Or would you be going to publish the whole component in here?

I'd like to use it in a few places, but if there's the danger that it might stop working immediately at some point, that would be a great danger.

Kind Regards, Florian

adeelraza commented 5 years ago

@DigitalFlow In the unlikely event that we discontinue the editor, we'll make it open source.

DigitalFlow commented 5 years ago

@adeelraza That's great to hear, thanks a lot.

Just found your example templates at emailmonster.io, really great stuff, again thanks for providing it.

sparkbold commented 5 years ago

I know this issue has been closed but I wonder if we still can use your app without calling home. Our corp network block adminapi call. And now the app just kept spinning without loading anything. Thank you.

AlexCharlton93 commented 5 years ago

@sparkbold Hi, we are also currently experiencing this issue, but we wasn't entirely sure if it's our corp network blocking adminapi or unlayer blocking us. Did you find a work around to this? Currently awaiting confirmation from our half to see if it's our network blocking.

Thanks in advance, Alex

dotkas commented 4 years ago

Please, enable the ability to opt-out of usage tracking.