unlcms / project-herbie

Drupal 10 implementation at the University of Nebraska–Lincoln

https://cms.unl.edu

GNU General Public License v2.0

5 stars 6 forks source link

Add wdntemplates as composer dev dependency #10

Closed macburgee1 closed 5 years ago

macburgee1 commented 5 years ago

Currently, a developer must manually download wdntemplates at web/wdn. This issue seeks to use composer to download the library as a dev dependency.

macburgee1 commented 5 years ago

Composer is caching WDN, so updates are not pulled with composer update. Also, only run deploy script if unl/wdntemplates is a package being updated or installed.

macburgee1 commented 5 years ago

We could also make this optional by adding a flag '--no-wdn' or '--with-wdn'.

macburgee1 commented 5 years ago

Will conflict with #35 when merged.

macburgee1 commented 5 years ago

35 is committed. Need to resolve resulting merge conflicts.

macburgee1 commented 5 years ago

master has been merged into issue-10-wdn-composer.

Composer doesn't allow for custom flags or arguments to be passed via CLI. I'm going to investigate moving this functionality to a custom script that must be run separate from composer install or composer update; perhaps composer install-wdn.

macburgee1 commented 5 years ago

UnlScriptHander::deployWdn() is no longer run automatically. It must be executed with a composer command: composer install-wdn. This should address the issue of differing local development stacks and workflows.